Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish between SessionWithConnections and SessionWithConnectionEditing #3741

Merged
merged 1 commit into from Jun 1, 2023

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Jun 1, 2023

This formalizes some code that checks for 'session.makeConnection' (which embedded has) to be a SessionWithConnections and then 'session.addConnectionConf' to be SessionWithConnectionEditing (which embedded may not have)

Also cleans up the typescript a little (less use of Function)

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jun 1, 2023
@cmdcolin cmdcolin added internal and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Jun 1, 2023
@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #3741 (2204276) into main (463c4dc) will decrease coverage by 0.04%.
The diff coverage is 22.72%.

@@            Coverage Diff             @@
##             main    #3741      +/-   ##
==========================================
- Coverage   64.35%   64.32%   -0.04%     
==========================================
  Files         977      977              
  Lines       29897    29902       +5     
  Branches     7172     7179       +7     
==========================================
- Hits        19240    19233       -7     
- Misses      10491    10500       +9     
- Partials      166      169       +3     
Impacted Files Coverage Δ
...idget/components/dialogs/CloseConnectionDialog.tsx 0.00% <0.00%> (ø)
...ckSelectorWidget/components/tree/HamburgerMenu.tsx 31.34% <16.66%> (-7.72%) ⬇️
packages/core/util/types/index.ts 71.57% <100.00%> (+0.61%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin merged commit bcb76dc into main Jun 1, 2023
11 checks passed
@cmdcolin cmdcolin deleted the hier_hamburger_menu branch June 1, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant