Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create mixin for shared code between LinearWiggleDisplay and MultiWiggleLinearDisplay #3743

Merged
merged 5 commits into from Jun 2, 2023

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Jun 2, 2023

A fairy large set of code is duplicated that can be shared

It also creates a "Score" sub-menu on the trackMenu of both displays since the track menu was getting pretty lengthy

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jun 2, 2023
@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Jun 2, 2023
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #3743 (9017be8) into main (de5ada8) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 9017be8 differs from pull request most recent head 6548d71. Consider uploading reports for the commit 6548d71 to get more accurate results

@@            Coverage Diff             @@
##             main    #3743      +/-   ##
==========================================
+ Coverage   64.35%   64.39%   +0.04%     
==========================================
  Files         976      976              
  Lines       29868    29594     -274     
  Branches     7173     7094      -79     
==========================================
- Hits        19221    19057     -164     
+ Misses      10478    10372     -106     
+ Partials      169      165       -4     
Impacted Files Coverage Δ
...gle/src/LinearWiggleDisplay/models/configSchema.ts 100.00% <ø> (+16.66%) ⬆️
...rc/MultiLinearWiggleDisplay/models/configSchema.ts 87.50% <ø> (ø)
plugins/wiggle/src/shared/YScaleBar.tsx 87.50% <ø> (ø)
...ns/wiggle/src/LinearWiggleDisplay/models/model.tsx 86.48% <100.00%> (+14.78%) ⬆️
...ggle/src/MultiLinearWiggleDisplay/models/model.tsx 76.22% <100.00%> (+10.75%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin merged commit db6daa6 into main Jun 2, 2023
1 check passed
@cmdcolin cmdcolin deleted the shared_wiggle_mixin branch June 2, 2023 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant