Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blank lines in GFF crashing text-index #3747

Merged
merged 2 commits into from Jun 7, 2023
Merged

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Jun 6, 2023

No description provided.

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jun 6, 2023
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #3747 (61f58a8) into main (09af1d9) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main    #3747      +/-   ##
==========================================
- Coverage   64.40%   64.39%   -0.01%     
==========================================
  Files         976      976              
  Lines       29596    29598       +2     
  Branches     7100     7101       +1     
==========================================
+ Hits        19060    19061       +1     
- Misses      10371    10372       +1     
  Partials      165      165              
Impacted Files Coverage Δ
products/jbrowse-cli/src/types/gff3Adapter.ts 94.28% <66.66%> (-2.69%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Jun 7, 2023
@cmdcolin cmdcolin merged commit e4bcb64 into main Jun 7, 2023
10 of 11 checks passed
@cmdcolin cmdcolin deleted the fix_gff_blank_line branch June 7, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant