Adds safety checks on AlignmentsDisplay properties to avoid undefined rendering #3758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
Codecov Report
@@ Coverage Diff @@
## main #3758 +/- ##
==========================================
+ Coverage 64.10% 64.11% +0.01%
==========================================
Files 987 987
Lines 29663 29667 +4
Branches 7094 7097 +3
==========================================
+ Hits 19014 19020 +6
+ Misses 10485 10483 -2
Partials 164 164
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
carolinebridge
added
bug
cmdcolin
reviewed
Jun 28, 2023
plugins/alignments/src/LinearAlignmentsDisplay/models/model.tsx
Outdated
Show resolved
Hide resolved
cmdcolin
reviewed
Jun 29, 2023
| @@ -73,7 +73,7 @@ const TrackLabel = React.forwardRef<HTMLDivElement, Props>(function ( | |||
| }, | |||
| ...(session.getTrackActionMenuItems?.(trackConf) || []), | |||
| ...track.trackMenuItems(), | |||
| ].sort((a, b) => (b.priority || 0) - (a.priority || 0)) | |||
| ].sort((a, b) => (b?.priority || 0) - (a?.priority || 0)) | |||
There was a problem hiding this comment.
nitpick but is it true that this needs a nullish check?
There was a problem hiding this comment.
It was failing on that in testing -- again i wasn't able to explain why exactly it was happening (might have something to do w nextjs and alignments) but yeah.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User experience when opening 2+ AlignmentsTracks one after another using jbrowse-react-linear-genome-view: application would crash on some undefined properties (SNPCoverageDisplay.height, self.PileupDisplay.type, and .priority of menu items)
Might be something weird with next.js rendering / race conditions / not sure what; adding these checks resolves the issue.
Tested on the JBrowse 2 app and everything working the same as before.