Separate out PileupDisplay functionality shared with SyntenyDisplay into a Mixin #3781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ny to inherit separately with their own implementations
github-actions
bot
added
the
needs label triage
Codecov Report
@@ Coverage Diff @@
## lgv-synteny-color #3781 +/- ##
======================================================
+ Coverage 0 64.06% +64.06%
======================================================
Files 0 989 +989
Lines 0 29781 +29781
Branches 0 7130 +7130
======================================================
+ Hits 0 19080 +19080
- Misses 0 10536 +10536
- Partials 0 165 +165
... and 979 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
carolinebridge
force-pushed
the
pileup-synteny-display-refactor
branch
from
472f8e3
to
0ac6233
Compare
cmdcolin
reviewed
Jul 6, 2023
| @@ -22,7 +22,7 @@ import { makeImageData } from './makeImageData' | |||
| import { readConfObject } from '@jbrowse/core/configuration' | |||
|
|
|||
| export interface RenderArgsDeserialized extends BoxRenderArgsDeserialized { | |||
| colorBy?: { type: string; tag?: string; extra?: any } | |||
| colorBy?: { type: string; tag?: string; extra?: {} } | |||
There was a problem hiding this comment.
can extra be typed with Record<string,unknown> or ExtraColorBy or something?
cmdcolin
reviewed
Jul 6, 2023
|
|
||
| function ColorByCustomDlg(props: { | ||
| model: { | ||
| colorBy: any | ||
| colorBy: IColorByModel |
There was a problem hiding this comment.
is it possibly undefined e.g. colorBy?: IColorByModel?
|
looks good to me, looks like this merges into the other PR currently. can address comments there perhaps, they are typescript nits |
cmdcolin
pushed a commit
that referenced
this pull request
Jul 25, 2023
…nto a Mixin (#3781) * separating out shared functionality into a mixin for pileup and synteny to inherit separately with their own implementations * fixing lint with strict typing * mv interface to shared file and add maybe type back * revert change to package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes "nonsense" operations from the synteny view by separating shared functionality between it and pileup into a mixin they both implement separately.