Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move embedded demos to individual repos #3794

Merged
merged 5 commits into from Jul 11, 2023
Merged

Move embedded demos to individual repos #3794

merged 5 commits into from Jul 11, 2023

Conversation

cmdcolin
Copy link
Collaborator

Fixes #3778

This proposes two new scripts

"clone_demos.sh"

and

"push_demos.sh"

The process of updating the embedded demos is not fully automated but after a release you can

./clone_demos.sh # clones the github repos
./update_demos.sh # updates yarn.lock files with `yarn upgrade` to latest
./deploy_demos.sh # deploy demos to s3
./push_demos.sh # push updated yarn.lock files

The example repos are in my username's github space but could be moved also

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jul 11, 2023
@cmdcolin cmdcolin changed the title Delete embedded demos from main repo Move embedded demos to individual repos Jul 11, 2023
@cmdcolin cmdcolin added internal and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Jul 11, 2023
@rbuels
Copy link
Contributor

rbuels commented Jul 11, 2023 via email

@codecov
Copy link

codecov bot commented Jul 11, 2023 •
edited

Codecov Report

Merging #3794 (34a549d) into main (f090f3e) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 34a549d differs from pull request most recent head d3748d5. Consider uploading reports for the commit d3748d5 to get more accurate results

@@            Coverage Diff             @@
##             main    #3794      +/-   ##
==========================================
- Coverage   64.47%   64.45%   -0.02%     
==========================================
  Files         990      990              
  Lines       29578    29578              
  Branches     7093     7093              
==========================================
- Hits        19070    19065       -5     
- Misses      10343    10348       +5     
  Partials      165      165

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin
Copy link
Collaborator Author

I also split out a PUBLISHING.md from the CONTRIBUTING.md with the steps for publishing

@cmdcolin cmdcolin force-pushed the embedded_demos_move branch 2 times, most recently from 11ab282 to 93998af Compare July 11, 2023 17:07
@cmdcolin
Copy link
Collaborator Author

@rbuels should the demos be moved to GMOD org?

@rbuels
Copy link
Contributor

rbuels commented Jul 11, 2023

Yeah I think it would probably be good to move them there. Might be best to add "-template" or "-demo" to their repo names as well.

@cmdcolin cmdcolin force-pushed the embedded_demos_move branch 2 times, most recently from f3bb087 to a59652e Compare July 11, 2023 22:06
@cmdcolin
Copy link
Collaborator Author

appended -demo and under GMOD now

@cmdcolin cmdcolin merged commit 0149248 into main Jul 11, 2023
1 check passed
@cmdcolin cmdcolin deleted the embedded_demos_move branch July 11, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move embedded_demos to their own git repos(?)
2 participants
@cmdcolin @rbuels