Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SVG export compatibility by removing rgba strings #3825

Merged
merged 1 commit into from Jul 20, 2023

Conversation

cmdcolin
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jul 20, 2023
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Jul 20, 2023
@cmdcolin cmdcolin changed the title Remove alpha from rgba from SVG exports Fix SVG export compatibility by removing rgba strings Jul 20, 2023
@cmdcolin
Copy link
Collaborator Author

Possible fix for some aspects of #3799

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #3825 (b12e363) into main (a8318c1) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3825      +/-   ##
==========================================
- Coverage   64.42%   64.42%   -0.01%     
==========================================
  Files         995      995              
  Lines       29563    29569       +6     
  Branches     7092     7092              
==========================================
+ Hits        19047    19049       +2     
- Misses      10355    10359       +4     
  Partials      161      161              
Impacted Files Coverage Δ
...w/src/LinearGenomeView/svgcomponents/SVGHeader.tsx 85.18% <100.00%> (+0.56%) ⬆️
...ew/src/LinearGenomeView/svgcomponents/SVGRuler.tsx 87.09% <100.00%> (+0.88%) ⬆️
...src/LinearGenomeView/svgcomponents/SVGScalebar.tsx 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin merged commit 130aa25 into main Jul 20, 2023
11 checks passed
@cmdcolin cmdcolin deleted the strip_alpha_theme branch July 20, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant