Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactors and typescripting improvements #3882

Merged
merged 3 commits into from Aug 29, 2023
Merged

Minor refactors and typescripting improvements #3882

merged 3 commits into from Aug 29, 2023

Conversation

cmdcolin
Copy link
Collaborator

  • Remove some type any from Cytobands component
  • Modularizes some of the block handling code into smaller components

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Aug 29, 2023
@cmdcolin cmdcolin added internal and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Aug 29, 2023
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #3882 (4713c52) into main (a3196fa) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 55.22%.

@@            Coverage Diff             @@
##             main    #3882      +/-   ##
==========================================
- Coverage   64.45%   64.44%   -0.02%     
==========================================
  Files        1004     1004              
  Lines       29809    29823      +14     
  Branches     7154     7153       -1     
==========================================
+ Hits        19214    19220       +6     
- Misses      10429    10437       +8     
  Partials      166      166              
Files Changed Coverage Δ
...ins/authentication/src/DropboxOAuthModel/model.tsx 16.66% <0.00%> (ø)
plugins/authentication/src/OAuthModel/model.tsx 8.33% <0.00%> (ø)
...view/src/LinearGenomeView/components/Cytobands.tsx 2.77% <0.00%> (-0.68%) ⬇️
...enome-view/src/LinearGenomeView/components/util.ts 73.07% <ø> (ø)
...-view/src/LinearGenomeView/components/Scalebar.tsx 94.33% <91.30%> (+0.58%) ⬆️
...view/src/LinearGenomeView/components/Gridlines.tsx 92.85% <94.11%> (+0.54%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin merged commit 6ff140d into main Aug 29, 2023
11 checks passed
@cmdcolin cmdcolin deleted the refactors branch August 29, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant