Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eject react-script config from jbrowse-web and jbrowse-desktop #3885

Merged
merged 15 commits into from Aug 30, 2023

Conversation

cmdcolin
Copy link
Collaborator

This is a less heavy handed approach to #3852

We can try to reduce amount of config over time, but that PR aggressively tried to prune the amount of webpack config. This PR is comparatively more similar to "just running react-scripts eject" and keeping the result

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Aug 29, 2023
@cmdcolin cmdcolin added enhancement New feature or request dependencies Pull requests that update a dependency file and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Aug 29, 2023
@cmdcolin cmdcolin force-pushed the webpack_eject3 branch 2 times, most recently from d4ab6e4 to 6286b67 Compare August 29, 2023 20:53
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #3885 (8185afd) into main (a3196fa) will decrease coverage by 0.04%.
Report is 3 commits behind head on main.
The diff coverage is 58.00%.

@@            Coverage Diff             @@
##             main    #3885      +/-   ##
==========================================
- Coverage   64.45%   64.42%   -0.04%     
==========================================
  Files        1004     1004              
  Lines       29809    29789      -20     
  Branches     7154     7143      -11     
==========================================
- Hits        19214    19191      -23     
- Misses      10429    10432       +3     
  Partials      166      166              
Files Changed Coverage Δ
packages/app-core/src/ui/App/App.tsx 96.55% <ø> (ø)
packages/app-core/src/ui/App/ViewMenu.tsx 78.57% <ø> (ø)
...BaseFeatureWidget/BaseFeatureDetail/Attributes.tsx 96.55% <ø> (ø)
...eWidget/SequenceFeatureDetails/ProteinSequence.tsx 100.00% <ø> (ø)
packages/core/BaseFeatureWidget/util.tsx 73.68% <ø> (ø)
packages/core/TextSearch/TextSearchManager.ts 97.14% <ø> (ø)
packages/core/pluggableElementTypes/AdapterType.ts 83.33% <ø> (ø)
...uggableElementTypes/models/InternetAccountModel.ts 61.17% <0.00%> (ø)
...ementTypes/renderers/ServerSideRenderedContent.tsx 0.00% <0.00%> (ø)
packages/core/rpc/RpcManager.ts 70.58% <ø> (ø)
... and 153 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin merged commit 48dfe18 into main Aug 30, 2023
11 checks passed
@cmdcolin cmdcolin deleted the webpack_eject3 branch August 30, 2023 00:55
@cmdcolin cmdcolin changed the title Eject react-script config v2 Eject react-script config from jbrowse-web and jbrowse-desktop Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant