Avoid undefined getConf on assembly.configuration safeReference #3912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
Codecov Report
@@ Coverage Diff @@
## main #3912 +/- ##
=======================================
Coverage 64.37% 64.37%
=======================================
Files 1004 1004
Lines 29868 29871 +3
Branches 7158 7162 +4
=======================================
+ Hits 19227 19229 +2
- Misses 10476 10477 +1
Partials 165 165
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cmdcolin
added
bug
|
might merge for now, could investigate why that specific commit caused this, or why it caused such a crazy screenshot in #3911, but this does fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3911
The issue #3911 mentions the issue this bisects to, which may be somewhat of a red herring or at least is a bit odd. The ideal solution to me seems to be properly checking that the getConf config entry is defined