Remove some unused "renameReference" code in static/dynamic blocks #3920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
|
the block code could be further improved in some ways. the interregionpaddingblock extends baseblock, but baseblock has things like "refName" and "assembly" but interregionpadding blocks do not provide this. |
cmdcolin
added
internal
and removed
needs label triage
cmdcolin
force-pushed
the
refactor_blocks
branch
from
8646066
to
7ef51cc
Compare
|
the renameReference function is immutable (not mutating the block) so not necessarily at odds with the fact that the blocks are an mst view, but still probably an odd function to use |
cmdcolin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a function called renameReference on the blocks, but this code is unused and a bit hairy, I think it is probably ok to just remove. also converts the Array.prototype.reduce into plain for loop based "sum" helper