Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce amount of canvas commands issued to the dotplot renderer #3925

Merged
merged 1 commit into from Sep 12, 2023

Conversation

cmdcolin
Copy link
Collaborator

This fixes a visual glitch I observed in the dotplot renderer. In some cases, small miniscual <1px lines were left alongside the larger diagonals

before (see very thin lines extending from larger diagonals)
Screenshot from 2023-09-12 10-22-48

after (no more very thin lines)
Screenshot from 2023-09-12 10-22-59

this also reduces the amount of canvas drawing commands issued to the renderer, which should make it faster, as number of canvas commands can be a significant portion of render time

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Sep 12, 2023
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Sep 12, 2023
@cmdcolin
Copy link
Collaborator Author

note that a similar optimization already exists on the linearsyntenyrendering which has to update very fast on each frame during scrolls

@cmdcolin cmdcolin force-pushed the dotplot_small_segment_reduction branch from 6656690 to dde351d Compare September 12, 2023 14:53
@cmdcolin cmdcolin merged commit 320401f into main Sep 12, 2023
11 checks passed
@cmdcolin cmdcolin deleted the dotplot_small_segment_reduction branch September 12, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant