Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setting multiple hierarchical defaultCollapsed config options at initialization #3946

Merged
merged 1 commit into from Sep 25, 2023
Merged

Fix setting multiple hierarchical defaultCollapsed config options at initialization #3946

merged 1 commit into from Sep 25, 2023

Conversation

cmdcolin
Copy link
Collaborator

Fixes #3943

Removes "else if" logic to allow multiple settings to be specified

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Sep 25, 2023
@cmdcolin cmdcolin mentioned this pull request Sep 25, 2023
Closed
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Sep 25, 2023
@cmdcolin cmdcolin changed the title Allow setting multiple options at initialization in hierarchical defaultCollapsed config Fix setting multiple hierarchical defaultCollapsed config options at initialization Sep 25, 2023
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #3946 (4f46b8c) into main (77c58f6) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3946   +/-   ##
=======================================
  Coverage   63.72%   63.72%           
=======================================
  Files        1018     1018           
  Lines       30190    30188    -2     
  Branches     7200     7199    -1     
=======================================
- Hits        19239    19238    -1     
+ Misses      10787    10786    -1     
  Partials      164      164
Files Changed Coverage Δ
...ement/src/HierarchicalTrackSelectorWidget/model.ts 57.14% <100.00%> (-0.86%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

scottcain
scottcain approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@scottcain scottcain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me on the WB staging site. Thanks!

@cmdcolin cmdcolin merged commit 5b8b145 into main Sep 25, 2023
11 checks passed
@cmdcolin cmdcolin deleted the hierarchical_collapse branch September 25, 2023 17:19
@cmdcolin cmdcolin mentioned this pull request Oct 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottcain scottcain scottcain approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

defaultCollapsed.topLevelCategories turns off subCategories
2 participants
@cmdcolin @scottcain