Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade electron 26->27 to fix screen blanking #3980

Merged
merged 5 commits into from Oct 13, 2023
Merged

Upgrade electron 26->27 to fix screen blanking #3980

merged 5 commits into from Oct 13, 2023

Conversation

cmdcolin
Copy link
Collaborator

  • Removes ts-expect-error from electron.ts menu generation
  • Downgrades electron 26 to 25, following some reports of issues with 26 Jbrowse 2.7.0 crash #3979

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Oct 13, 2023
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #3980 (deffcdc) into main (4ab29d5) will decrease coverage by 0.02%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main    #3980      +/-   ##
==========================================
- Coverage   63.78%   63.77%   -0.02%     
==========================================
  Files        1020     1020              
  Lines       30134    30134              
  Branches     7194     7194              
==========================================
- Hits        19222    19217       -5     
- Misses      10745    10752       +7     
+ Partials      167      165       -2     
Files Coverage Δ
...erarchicalTrackSelectorWidget/generateHierarchy.ts 80.43% <100.00%> (ø)
...ement/src/HierarchicalTrackSelectorWidget/model.ts 57.14% <0.00%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Oct 13, 2023
@cmdcolin cmdcolin merged commit 6a6e5c3 into main Oct 13, 2023
1 check passed
@cmdcolin cmdcolin deleted the bump_deps branch October 13, 2023 23:43
@cmdcolin cmdcolin changed the title Downgrade electron 26->25 to fix screen blanking Upgrade electron 26->27 to fix screen blanking Oct 18, 2023
@cmdcolin
Copy link
Collaborator Author

changed title to reflect that it was actually upgraded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant