Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip baseUri in 'About track' copy config #4040

Merged
merged 1 commit into from Nov 3, 2023
Merged

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Nov 3, 2023

Fixes #3884

this is the same technique the entire 'jbrowse' object uses at a high level, but just added for this particular location for copying the track config

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Nov 3, 2023
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #4040 (7bf43d1) into main (62826c1) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #4040      +/-   ##
==========================================
+ Coverage   63.61%   63.64%   +0.02%     
==========================================
  Files        1029     1029              
  Lines       30296    30304       +8     
  Branches     7211     7213       +2     
==========================================
+ Hits        19274    19287      +13     
+ Misses      10856    10849       -7     
- Partials      166      168       +2     
Files Coverage Δ
...ckages/product-core/src/ui/AboutDialogContents.tsx 48.38% <0.00%> (-16.84%) ⬇️

... and 3 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Nov 3, 2023
@cmdcolin cmdcolin merged commit aad64cd into main Nov 3, 2023
11 checks passed
@cmdcolin cmdcolin deleted the strip_base_uri_abouttrack branch November 3, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

About track->"Copy config" includes baseUri entries on UriLocation objects
1 participant