Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in "Open session" widget for sessions that have 'track-less views' #4043

Merged
merged 2 commits into from Nov 6, 2023

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Nov 6, 2023

some view types, e.g. MsaView, do not have any tracks, and this caused the Open session widget to crash (it tries to calculate sum of all view.tracks)

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Nov 6, 2023
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #4043 (4b4236c) into main (f12cb41) will decrease coverage by 0.02%.
The diff coverage is 45.83%.

❗ Current head 4b4236c differs from pull request most recent head fba1d65. Consider uploading reports for the commit fba1d65 to get more accurate results

@@            Coverage Diff             @@
##             main    #4043      +/-   ##
==========================================
- Coverage   63.63%   63.62%   -0.02%     
==========================================
  Files        1029     1031       +2     
  Lines       30304    30309       +5     
  Branches     7213     7218       +5     
==========================================
- Hits        19284    19283       -1     
- Misses      10854    10859       +5     
- Partials      166      167       +1     
Files Coverage Δ
...ionManager/components/DeleteSavedSessionDialog.tsx 0.00% <ø> (ø)
...s/src/SessionManager/components/SessionManager.tsx 100.00% <100.00%> (+61.36%) ⬆️
...browse-web/src/components/SessionWarningDialog.tsx 41.17% <ø> (ø)
...essionManager/components/AutosavedSessionsList.tsx 58.82% <58.82%> (ø)
...ionManager/components/RegularSavedSessionsList.tsx 34.48% <34.48%> (ø)

... and 3 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Nov 6, 2023
@cmdcolin cmdcolin merged commit fb97715 into main Nov 6, 2023
10 of 11 checks passed
@cmdcolin cmdcolin deleted the notracks_opensession branch November 6, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant