Fix Mac auto-updates fetching non-existent zip #4071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4071 +/- ##
=======================================
Coverage 63.19% 63.19%
=======================================
Files 1044 1044
Lines 30551 30551
Branches 7289 7289
=======================================
Hits 19307 19307
Misses 11073 11073
Partials 171 171 ☔ View full report in Codecov by Sentry. |
cmdcolin
added
bug
cmdcolin
changed the title
cmdcolin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was observed on chat that the auto-update was not working on mac
This is due to the 'zip' files being unavailable for mac in the release in v2.7.2 forward which was a change that was unintentionally introduced by #4011
This restores the zip file build
we could "potentially" restore the zip file builds on both v2.7.2 and v2.8.0 but it might be tricky to create proper app signing for them, so it might just be worth cutting a new release with the restored zip file and then the auto-updater will just look for the latest release