Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll both panels of the linear synteny view when side scrolling the middle panel #4110

Merged
merged 1 commit into from Dec 2, 2023

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Dec 1, 2023

Split out from #4109 as it's pretty separate

This just is a small usability improvement for side-wheel scrolling the side panel. Potentially it could include a click and drag also, it would just have to be smart enough to avoid behavior of clicking on a feature

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Dec 1, 2023
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (88c57a9) 63.51% compared to head (38b8ebe) 63.50%.

Files Patch % Lines
...ntenyDisplay/components/LinearSyntenyRendering.tsx 16.66% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4110      +/-   ##
==========================================
- Coverage   63.51%   63.50%   -0.01%     
==========================================
  Files        1057     1057              
  Lines       30713    30725      +12     
  Branches     7327     7329       +2     
==========================================
+ Hits        19506    19512       +6     
- Misses      11035    11041       +6     
  Partials      172      172              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Dec 2, 2023
@cmdcolin cmdcolin merged commit 9021955 into main Dec 2, 2023
11 checks passed
@cmdcolin cmdcolin deleted the dual_scroll branch December 2, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant