Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove session.notify after using the Add track workflow #4123

Merged
merged 1 commit into from Dec 11, 2023

Conversation

cmdcolin
Copy link
Collaborator

Currently, after any usage of the Add track workflow, and an "info" level alert snackbar says

"Open a new view, or use the track selector in an existing view, to view this track"

However the "Add track" workflow automatically shows the track in the "current view", so I think this message may be unneeded. I would suggest removing, but it could also be re-phrased to tell the user that it was added to the current view and it is available in the track selector

@cmdcolin
Copy link
Collaborator Author

also there is a case where there is no "current view" however if you use the global File->Open track with no views open it alerts "Please open a view to add a track first" so it seems unlikely for this to occur

@cmdcolin cmdcolin added the enhancement New feature or request label Dec 11, 2023
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (8d445a9) 63.40% compared to head (1a849cd) 63.40%.

Files Patch % Lines
...TrackWidget/components/DefaultAddTrackWorkflow.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4123      +/-   ##
==========================================
- Coverage   63.40%   63.40%   -0.01%     
==========================================
  Files        1057     1057              
  Lines       30779    30777       -2     
  Branches     7330     7329       -1     
==========================================
- Hits        19516    19513       -3     
- Misses      11090    11091       +1     
  Partials      173      173              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmdcolin cmdcolin merged commit 08d77ac into main Dec 11, 2023
10 checks passed
@cmdcolin cmdcolin deleted the remove_notify branch December 11, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant