Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split "recently used tracks" local storage keys by view assemblies #4135

Merged
merged 2 commits into from Dec 14, 2023

Conversation

cmdcolin
Copy link
Collaborator

Fixes #4098
Fixes #4111

It also fixes the order in the recently used panel. The order shipped in v2.9.0 is not in any particular order, now the latest is at the bottom. This was a somewhat subtle bug because the order was actually the order basically from the config.json

Note that this would lose the recently used entries that anyone accumulated through using v2.9.0 but hopefully not too bad to have that happen...

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (d0df21b) 63.27% compared to head (6a5cb95) 63.19%.
Report is 1 commits behind head on main.

Files Patch % Lines
...ement/src/HierarchicalTrackSelectorWidget/model.ts 79.41% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4135      +/-   ##
==========================================
- Coverage   63.27%   63.19%   -0.08%     
==========================================
  Files        1061     1061              
  Lines       30989    31004      +15     
  Branches     7382     7385       +3     
==========================================
- Hits        19608    19594      -14     
- Misses      11209    11238      +29     
  Partials      172      172              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmdcolin cmdcolin force-pushed the recently_used_container branch 2 times, most recently from e88f1b8 to bfae6b1 Compare December 14, 2023 02:55
@cmdcolin cmdcolin merged commit 3c7b8a8 into main Dec 14, 2023
10 checks passed
@cmdcolin cmdcolin deleted the recently_used_container branch December 14, 2023 12:47
@cmdcolin cmdcolin added the enhancement New feature or request label Dec 15, 2023
@cmdcolin cmdcolin changed the title Split recently used local storage keys by view.assemblyNames Split "recently used tracks" local storage keys by view assemblies Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant