Speed up large FromConfigAdapter usages with alternative adapter id calculation #4138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
on second thought: this may not be an actual speed up. might need to develop a method for using dev versions of @jbrowse/react-linear-genome-view in dash_jbrowse, and then dev version of dash_jbrowse in jbrowse-jupyter |
cmdcolin
changed the title
|
re-fixed, and re-titled pr to reflect the new proper speedup |
cmdcolin
force-pushed
the
speed_up_fromconfig
branch
from
2f35cbd
to
84cceea
Compare
cmdcolin
changed the title
cmdcolin
force-pushed
the
speed_up_fromconfig
branch
from
84cceea
to
d372be7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Large FromConfigAdapter may be used for things like data frame tracks in jbrowse jupyter
Future usages of jbrowse-jupyter may create e.g. a custom adapter type, but this may help in the interim