Remove --tracks and --view options from set-default-session CLI #4146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmdcolin
force-pushed
the
set_default_session
branch
from
fd11be5
to
604226a
Compare
cmdcolin
force-pushed
the
set_default_session
branch
from
604226a
to
9c7bba3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4146 +/- ##
==========================================
- Coverage 63.13% 63.09% -0.05%
==========================================
Files 1064 1064
Lines 31060 31033 -27
Branches 7411 7403 -8
==========================================
- Hits 19609 19579 -30
- Misses 11280 11283 +3
Partials 171 171 ☔ View full report in Codecov by Sentry. |
|
might go ahead with merge. if we make an alternative system with session spec, it may be a new cli command |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These options were created very early on but they have not worked for awhile and generated incomplete state snapshots of the session which could not be loaded
the alternative to removing this would be to either (a) make the CLI make a more complete snapshot or (b) make our code allow incomplete state snapshots to load
fixes #2708