Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad svg output in v2.10.0 in cases where feature names have angle brackets #4147

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

cmdcolin
Copy link
Collaborator

removes the ">"->">" replacement in the manual export svg code. this code was really only to support the dangerouslySetInnerHTML case, which is now removed

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (551da33) 63.13% compared to head (81035a5) 63.12%.

❗ Current head 81035a5 differs from pull request most recent head dc70dd2. Consider uploading reports for the commit dc70dd2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4147      +/-   ##
==========================================
- Coverage   63.13%   63.12%   -0.01%     
==========================================
  Files        1064     1064              
  Lines       31060    31059       -1     
  Branches     7411     7411              
==========================================
- Hits        19609    19607       -2     
- Misses      11280    11281       +1     
  Partials      171      171              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmdcolin cmdcolin merged commit d2f38c9 into main Dec 20, 2023
10 checks passed
@cmdcolin cmdcolin deleted the remove_replace branch December 20, 2023 20:42
@cmdcolin cmdcolin added the bug Something isn't working label Jan 4, 2024
@cmdcolin cmdcolin mentioned this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant