Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add directional feet to breakends in linear arc display #4152

Merged
merged 2 commits into from Dec 22, 2023

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Dec 22, 2023

The little feet can improve breakend interpretation

image

fixes #4051

@cmdcolin cmdcolin changed the title Directional feet breakend to linear arc display Add directional feet to breakends in linear arc display Dec 22, 2023
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (06a94fe) 63.18% compared to head (64cf7b9) 63.08%.

Files Patch % Lines
...arc/src/LinearPairedArcDisplay/components/Arcs.tsx 0.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4152      +/-   ##
==========================================
- Coverage   63.18%   63.08%   -0.11%     
==========================================
  Files        1064     1064              
  Lines       31059    31072      +13     
  Branches     7411     7415       +4     
==========================================
- Hits        19626    19602      -24     
- Misses      11261    11301      +40     
+ Partials      172      169       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmdcolin cmdcolin merged commit e283f59 into main Dec 22, 2023
10 checks passed
@cmdcolin cmdcolin deleted the directional_feet_breakends_arc branch December 22, 2023 17:40
@cmdcolin cmdcolin added the enhancement New feature or request label Jan 4, 2024
@cmdcolin cmdcolin mentioned this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add directional feet to LinearPairedArcDisplay
1 participant