Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metadata facet filters being blank #4154

Merged
merged 3 commits into from Dec 31, 2023
Merged

Conversation

cmdcolin
Copy link
Collaborator

Reported by @scottcain

Bottom right is empty

image

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (06a94fe) 63.18% compared to head (1701a5e) 63.08%.
Report is 1 commits behind head on main.

Files Patch % Lines
...icalTrackSelectorWidget/components/faceted/util.ts 0.00% 5 Missing ⚠️
...SelectorWidget/components/faceted/FacetFilters.tsx 0.00% 3 Missing ⚠️
...ement/src/HierarchicalTrackSelectorWidget/model.ts 0.00% 3 Missing ⚠️
...kSelectorWidget/components/faceted/FacetFilter.tsx 0.00% 2 Missing ⚠️
...ectorWidget/components/faceted/FacetedSelector.tsx 0.00% 1 Missing ⚠️
...rc/HierarchicalTrackSelectorWidget/facetedModel.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4154      +/-   ##
==========================================
- Coverage   63.18%   63.08%   -0.11%     
==========================================
  Files        1064     1065       +1     
  Lines       31059    31064       +5     
  Branches     7411     7413       +2     
==========================================
- Hits        19626    19597      -29     
- Misses      11261    11298      +37     
+ Partials      172      169       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmdcolin cmdcolin added the bug Something isn't working label Dec 31, 2023
@cmdcolin cmdcolin merged commit bdf83ec into main Dec 31, 2023
10 checks passed
@cmdcolin cmdcolin deleted the metadata_facet_filters branch December 31, 2023 15:08
@cmdcolin cmdcolin mentioned this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant