Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove react-svg-tooltip library #4155

Merged
merged 4 commits into from Dec 31, 2023
Merged

Remove react-svg-tooltip library #4155

merged 4 commits into from Dec 31, 2023

Conversation

cmdcolin
Copy link
Collaborator

this is pretty minor but it removes a library react-arc-tooltip that gave peer dependency warnings, and uses a tooltip more similar to other places in the codebase

Copy link

codecov bot commented Dec 30, 2023

Codecov Report

Attention: 72 lines in your changes are missing coverage. Please review.

Comparison is base (e283f59) 63.07% compared to head (03945ab) 63.12%.

Files Patch % Lines
.../arc/src/LinearPairedArcDisplay/components/util.ts 0.00% 33 Missing ⚠️
plugins/arc/src/ArcTooltip.tsx 15.00% 17 Missing ⚠️
...arc/src/LinearPairedArcDisplay/components/Arcs.tsx 0.00% 16 Missing ⚠️
plugins/arc/src/ArcRenderer/ArcRendering.tsx 25.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4155      +/-   ##
==========================================
+ Coverage   63.07%   63.12%   +0.04%     
==========================================
  Files        1064     1066       +2     
  Lines       31072    31096      +24     
  Branches     7415     7426      +11     
==========================================
+ Hits        19599    19629      +30     
+ Misses      11304    11295       -9     
- Partials      169      172       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmdcolin cmdcolin changed the title Remove react-arc-tooltip library Remove react-svg-tooltip library Dec 31, 2023
@cmdcolin cmdcolin added bug Something isn't working housekeeping needs to be tidied up, is a drag on team performance enhancement New feature or request and removed bug Something isn't working labels Dec 31, 2023
@cmdcolin cmdcolin merged commit 951e987 into main Dec 31, 2023
10 checks passed
@cmdcolin cmdcolin deleted the new_arc_tooltip branch December 31, 2023 15:06
@cmdcolin cmdcolin mentioned this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request housekeeping needs to be tidied up, is a drag on team performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant