Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix @jbrowse/img under node environment #4208

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Fix @jbrowse/img under node environment #4208

merged 2 commits into from
Feb 16, 2024

Conversation

cmdcolin
Copy link
Collaborator

Fixes #4205

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b6c1c22) 62.87% compared to head (b25951b) 62.88%.

Files Patch % Lines
products/jbrowse-img/src/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4208   +/-   ##
=======================================
  Coverage   62.87%   62.88%           
=======================================
  Files        1070     1071    +1     
  Lines       31176    31179    +3     
  Branches     7445     7445           
=======================================
+ Hits        19603    19608    +5     
  Misses      11402    11402           
+ Partials      171      169    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmdcolin cmdcolin merged commit 6164437 into main Feb 16, 2024
10 checks passed
@cmdcolin cmdcolin deleted the fix_jbimg branch February 16, 2024 14:56
@cmdcolin cmdcolin changed the title Fix @jbrowse/img tests to run under node environment Fix @jbrowse/img under node environment Feb 16, 2024
@cmdcolin cmdcolin added the bug Something isn't working label Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@jbrowse/img not working with "window"
1 participant