Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breakpoint split view SVG export occasionally having wrong clipping #4217

Merged
merged 2 commits into from Feb 19, 2024

Conversation

cmdcolin
Copy link
Collaborator

Fixes #4216

It is actually somewhat unclear to me why this is needed, but the clip id appears to be duplicated in the breakpoint split view (top and bottom panels) and is effectively deduped by the addition of a randomness. the randomness is suppressed in jest snapshots since it causes snapshot tests to be unstable

Back

Working

Working
@cmdcolin cmdcolin changed the title Dedupe clipping id in SVG export Fix breakpoint split view SVG export occasionally having wrong clipping Feb 19, 2024
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (39a61ca) 62.90% compared to head (65c157a) 62.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4217      +/-   ##
==========================================
- Coverage   62.90%   62.88%   -0.02%     
==========================================
  Files        1071     1071              
  Lines       31199    31200       +1     
  Branches     7455     7455              
==========================================
- Hits        19626    19621       -5     
- Misses      11400    11408       +8     
+ Partials      173      171       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmdcolin
Copy link
Collaborator Author

debugged that this occurs due to the launch breakpoint split view creating two views with the same displayId when it "ports the snapshot of the tracks it was launched from" to the new view. this PR can continue, but the breakpoint split view can strip the displayIds so that it doesnt need this workaround

@cmdcolin cmdcolin merged commit cdd6716 into main Feb 19, 2024
10 checks passed
@cmdcolin cmdcolin deleted the fix_clipping branch February 19, 2024 12:49
@cmdcolin cmdcolin added the bug Something isn't working label Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SVG export over-clipping on breakpoint split view example
1 participant