Fix hydration error from translocation features in plaintext VCF adapter #4220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmdcolin
force-pushed
the
fix_hydrate
branch
from
9bfcc75
to
769d78e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the mismatch was between trying to do a 'premature optimization' of lazily creating VcfFeature objects, and manually calculating feature.start and feature.end from the plaintext line before the VcfFeature was created instead of relying on VcfFeature parsing of the line, but turns out parsing the start/end is not easy, so this removes the lazy creating routine which fixes feature.start and feature.end parsing (which downstream fixes the hydration error)
fixes #4214