Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of BAM and CRAM refNames that contain a colon #4224

Merged
merged 3 commits into from
Feb 20, 2024

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Feb 20, 2024

This just bumps the @gmod/bam parser version which contains a fix for this xref GMOD/bam-js#103

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b3c057e) 62.68% compared to head (220572c) 62.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4224      +/-   ##
==========================================
- Coverage   62.68%   62.68%   -0.01%     
==========================================
  Files        1084     1084              
  Lines       31315    31315              
  Branches     7474     7474              
==========================================
- Hits        19631    19630       -1     
- Misses      11512    11513       +1     
  Partials      172      172              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmdcolin cmdcolin merged commit a6d1002 into main Feb 20, 2024
10 checks passed
@cmdcolin cmdcolin deleted the fix_bam_refnames branch February 20, 2024 19:11
@cmdcolin cmdcolin changed the title Fix parsing of BAM refNames that contain a colon Fix parsing of BAM and CRAM refNames that contain a colon Feb 20, 2024
@cmdcolin cmdcolin added the bug Something isn't working label Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant