Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow getting stack trace from track errors #4255

Merged
merged 4 commits into from Mar 4, 2024
Merged

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Mar 4, 2024

The track errors do not use the "ErrorMessage" component with the built-in stack trace button so PR adds a the stack trace button to track errors

image

it works for web worker errors

image

I replaced the "API" of the BlockMsg component to make "action" a React.ReactNode instead of just a function, therefore any amount of stuff can be placed, and I just use IconButton instead of the "Reload" text

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 29.03226% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 62.59%. Comparing base (4f5b046) to head (ce58a82).

Files Patch % Lines
packages/core/ui/ErrorMessageStackTraceDialog.tsx 0.00% 6 Missing ⚠️
...iredArcDisplay/components/BaseDisplayComponent.tsx 0.00% 5 Missing ⚠️
packages/product-core/src/ui/FileInfoPanel.tsx 25.00% 3 Missing ⚠️
...get/components/dialogs/ManageConnectionsDialog.tsx 0.00% 3 Missing ⚠️
...play/components/ServerSideRenderedBlockContent.tsx 57.14% 3 Missing ⚠️
...ins/alignments/src/shared/BaseDisplayComponent.tsx 0.00% 1 Missing ⚠️
.../src/BaseLinearDisplay/components/LinearBlocks.tsx 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4255      +/-   ##
==========================================
- Coverage   62.63%   62.59%   -0.04%     
==========================================
  Files        1086     1086              
  Lines       31387    31391       +4     
  Branches     7498     7493       -5     
==========================================
- Hits        19659    19649      -10     
- Misses      11556    11569      +13     
- Partials      172      173       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmdcolin cmdcolin merged commit 12bf29d into main Mar 4, 2024
10 checks passed
@cmdcolin cmdcolin deleted the stack_trace_track branch March 4, 2024 16:18
@cmdcolin cmdcolin added the enhancement New feature or request label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant