Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smaller sequence track size #4257

Merged
merged 4 commits into from Mar 4, 2024
Merged

Smaller sequence track size #4257

merged 4 commits into from Mar 4, 2024

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Mar 4, 2024

Fixes #4229

Also moves rowHeight to a volatile, as if it's model, it will use the old size, so old sessions will not get updated

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.59%. Comparing base (4f5b046) to head (a5e035a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4257      +/-   ##
==========================================
- Coverage   62.63%   62.59%   -0.04%     
==========================================
  Files        1086     1086              
  Lines       31387    31392       +5     
  Branches     7498     7493       -5     
==========================================
- Hits        19659    19651       -8     
- Misses      11556    11568      +12     
- Partials      172      173       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Mar 4, 2024

this branch

image

main

image

@cmdcolin cmdcolin merged commit 58d1fca into main Mar 4, 2024
10 checks passed
@cmdcolin cmdcolin deleted the smaller_seq_track branch March 4, 2024 17:40
@cmdcolin cmdcolin added the enhancement New feature or request label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce height of sequence track rows by default
1 participant