Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bookmark highlight to overview scale bar #4266

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

carolinebridge
Copy link
Contributor

  • adds highlights to overview scale bar for bookmarks
  • adds new extension point OverviewScalebarComponent to accomplish this
  • aligns styling between bookmark highlights and url param highlights

Screenshot 2024-03-06 at 3 55 47 PM
Screenshot 2024-03-06 at 3 55 08 PM

Outlines for comparison (I think they might make the regions more visible in the overview scale bar):
Screenshot 2024-03-06 at 11 41 00 AM

Resolves #4246

@carolinebridge carolinebridge added the enhancement New feature or request label Mar 6, 2024
@carolinebridge carolinebridge self-assigned this Mar 6, 2024
@carolinebridge
Copy link
Contributor Author

carolinebridge commented Mar 6, 2024

Todos:

  • Decide on border or no border on highlights
  • I think having the border on the Overview and none on the track is a good compromise for visibility?
  • Add theme config option for URL param highlight instead of using quaternary color
  • default theming uses the same quat. color

@carolinebridge
Copy link
Contributor Author

Screenshot 2024-03-08 at 10 31 11 AM Screenshot 2024-03-08 at 10 31 32 AM

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 62.64%. Comparing base (c8fc800) to head (3225693).
Report is 4 commits behind head on main.

Files Patch % Lines
...kWidget/components/Highlight/OverviewHighlight.tsx 87.09% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4266      +/-   ##
==========================================
- Coverage   62.68%   62.64%   -0.04%     
==========================================
  Files        1087     1088       +1     
  Lines       31392    31427      +35     
  Branches     7493     7505      +12     
==========================================
+ Hits        19678    19688      +10     
- Misses      11538    11563      +25     
  Partials      176      176              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@carolinebridge carolinebridge marked this pull request as ready for review March 8, 2024 15:46
@@ -25,19 +25,18 @@ const useStyles = makeStyles()(theme => ({
highlight: {
height: '100%',
position: 'absolute',
background: `${colord(theme.palette.quaternary?.main ?? 'goldenrod')
overflow: 'hidden',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason for overflow: hidden being added here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without it, the icon on the highlight always shows (so if you're zoomed out and the highlight is a sliver you see it)

realistically, anything you're highlighting and looking at, you'd be a close enough zoom level to make use of the icon options, i think

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good. i had this idea that possibly the link icon could even be hidden if the user is not hovering over, as the user might like it hidden for e.g. screenshot. just an idea though

@cmdcolin cmdcolin merged commit c7dc049 into main Mar 8, 2024
10 checks passed
@cmdcolin cmdcolin deleted the add-overview-highlights-to-bookmarks branch March 8, 2024 16:47
@cmdcolin
Copy link
Collaborator

cmdcolin commented Mar 8, 2024

fixed #4130 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add highlight on overview scale bar for bookmarks with on-hover labels
2 participants