Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid crash on badly encoded GFF attributes #4269

Merged
merged 2 commits into from Mar 7, 2024
Merged

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Mar 7, 2024

Some files are badly encoded (not following e.g. GFF3 spec) and cause decodeURIComponent to throw. This is not a good user experience. This PR just proposes passing the string along

addresses #4268

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 62.59%. Comparing base (c8fc800) to head (bc338d9).
Report is 3 commits behind head on main.

Files Patch % Lines
packages/text-indexing/src/util.ts 0.00% 4 Missing ⚠️
packages/text-indexing/src/types/vcfAdapter.ts 0.00% 3 Missing ⚠️
products/jbrowse-cli/src/util.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4269      +/-   ##
==========================================
- Coverage   62.68%   62.59%   -0.10%     
==========================================
  Files        1087     1087              
  Lines       31392    31404      +12     
  Branches     7493     7497       +4     
==========================================
- Hits        19678    19656      -22     
- Misses      11538    11575      +37     
+ Partials      176      173       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmdcolin cmdcolin merged commit 67d5877 into main Mar 7, 2024
10 checks passed
@cmdcolin cmdcolin deleted the decode_uri_component branch March 7, 2024 21:47
@cmdcolin cmdcolin changed the title Use a "no throw" version of decodeURIComponent for text indexing Avoid crash on badly encoded GFF attributes Mar 13, 2024
@cmdcolin cmdcolin added the bug Something isn't working label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant