Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bug on URL highlight param in which refName aliases were not working #4275

Merged
merged 4 commits into from
Mar 8, 2024

Conversation

@carolinebridge carolinebridge added the bug Something isn't working label Mar 8, 2024
@carolinebridge carolinebridge self-assigned this Mar 8, 2024
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 21.42857% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 62.59%. Comparing base (67d5877) to head (dcccb54).

Files Patch % Lines
...view/src/LinearGenomeView/components/Highlight.tsx 16.66% 5 Missing ⚠️
.../LinearGenomeView/components/OverviewHighlight.tsx 33.33% 4 Missing ⚠️
...ar-genome-view/src/LaunchLinearGenomeView/index.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4275      +/-   ##
==========================================
- Coverage   62.60%   62.59%   -0.01%     
==========================================
  Files        1087     1087              
  Lines       31404    31413       +9     
  Branches     7497     7501       +4     
==========================================
+ Hits        19659    19664       +5     
- Misses      11572    11574       +2     
- Partials      173      175       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -95,7 +96,16 @@ const Highlight = observer(function Highlight({ model }: { model: LGV }) {
: undefined
}

const h = mapCoords(model.highlight)
const asm = assemblyManager.assemblies.find(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can use assemblyManager.get(model.highlight.assemblyName) instead of find here

@cmdcolin cmdcolin merged commit 72d6402 into main Mar 8, 2024
10 checks passed
@cmdcolin cmdcolin deleted the fix-ref-name-highlight branch March 8, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URL highlight does not appear with refName aliases
2 participants