Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON.parse utility to the "jexl function library" #4280

Merged
merged 1 commit into from Mar 12, 2024

Conversation

cmdcolin
Copy link
Collaborator

This adds a JSON.parse utility to the jexl functions. It is a little specialized but this can enable a sort of (office hours) use case where a table of data can be stored in a GFF3 attribute as a json "array of objects". A volvox track showing this use case is added in this PR too

The alternative is that this isn't a built in utility but doesn't seem too bad to add it

image

@cmdcolin cmdcolin force-pushed the add_json_parse_jexl branch 2 times, most recently from 49098e6 to e902859 Compare March 12, 2024 14:58
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.59%. Comparing base (ddae2c9) to head (3e7b49c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4280      +/-   ##
==========================================
- Coverage   62.66%   62.59%   -0.07%     
==========================================
  Files        1088     1088              
  Lines       31459    31460       +1     
  Branches     7515     7515              
==========================================
- Hits        19713    19692      -21     
- Misses      11568    11591      +23     
+ Partials      178      177       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmdcolin
Copy link
Collaborator Author

should be harmless enough :)

@cmdcolin cmdcolin merged commit 0720fde into main Mar 12, 2024
10 checks passed
@cmdcolin cmdcolin deleted the add_json_parse_jexl branch March 12, 2024 22:05
@cmdcolin cmdcolin added the enhancement New feature or request label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant