Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow getting stack trace error dialog from session.notify errors #4284

Merged
merged 5 commits into from
Mar 13, 2024

Conversation

cmdcolin
Copy link
Collaborator

Fixes #1968

This adds a function called session.notifyError that has a different signature from session.notify. Differences of session.notifyError with session.notify

  • allows it to have a default "action" (third param of session.notify)
  • passes the entire error object (which contains stack trace) instead of string message
  • also can pass an "extra" param that contains any extra info (like snapshot of session state)

@cmdcolin cmdcolin force-pushed the session_notify_error branch 2 times, most recently from 28c3efd to 4131758 Compare March 12, 2024 20:56
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 48.33333% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 62.58%. Comparing base (82f305e) to head (ce4f34e).

Files Patch % Lines
packages/core/ui/ErrorMessageStackTraceDialog.tsx 0.00% 5 Missing ⚠️
packages/core/ui/SnackbarModel.tsx 78.26% 5 Missing ⚠️
products/jbrowse-desktop/src/rootModel/Menus.ts 0.00% 4 Missing ⚠️
...tenyDisplay/components/LaunchSyntenyViewDialog.tsx 0.00% 2 Missing ⚠️
...arSyntenyDisplay/components/SyntenyContextMenu.tsx 0.00% 2 Missing ⚠️
...earPileupDisplay/SharedLinearPileupDisplayMixin.ts 0.00% 1 Missing ⚠️
...kpoint-split-view/src/BreakpointSplitView/model.ts 0.00% 1 Missing ⚠️
...ins/data-management/src/ucsc-trackhub/doConnect.ts 0.00% 1 Missing ⚠️
...plot-view/src/DotplotReadVsRef/DotplotReadVsRef.ts 0.00% 1 Missing ⚠️
plugins/dotplot-view/src/LaunchDotplotView.ts 0.00% 1 Missing ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4284      +/-   ##
==========================================
- Coverage   62.60%   62.58%   -0.02%     
==========================================
  Files        1088     1088              
  Lines       31502    31498       -4     
  Branches     7531     7530       -1     
==========================================
- Hits        19721    19713       -8     
- Misses      11604    11611       +7     
+ Partials      177      174       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmdcolin cmdcolin force-pushed the session_notify_error branch 2 times, most recently from 47cea56 to 508bc3b Compare March 13, 2024 15:10
@cmdcolin cmdcolin merged commit 81e4528 into main Mar 13, 2024
10 checks passed
@cmdcolin cmdcolin deleted the session_notify_error branch March 13, 2024 16:43
@cmdcolin cmdcolin added the enhancement New feature or request label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If session fails to load, give user option to submit it to us
1 participant