Fix snap package and also add deb package #4287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmdcolin
force-pushed
the
remove_snap_package
branch
from
849bb5f
to
7252c06
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4287 +/- ##
==========================================
- Coverage 62.60% 62.59% -0.01%
==========================================
Files 1088 1088
Lines 31496 31496
Branches 7528 7528
==========================================
- Hits 19719 19716 -3
- Misses 11602 11607 +5
+ Partials 175 173 -2 ☔ View full report in Codecov by Sentry. |
cmdcolin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes influence from how the mac "multiple targets" config is defined (as an array of objects with "target" key within an array of targets within the OS specific grouping)
this was made from studying https://www.electron.build/configuration/linux
it is allowed for there to be a top level snap key, as before, but this changes it to be inside the linux grouping
more linux builds (.tar.gz, deb, etc) could be added also