Create GCContentTrack type #4288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmdcolin
commented
Mar 14, 2024
| @@ -49,11 +49,13 @@ const ErrorMessage = ({ | |||
| onReset?: () => void | |||
| }) => { | |||
| const str = `${error}` | |||
| const str2 = str.indexOf('expected an instance of') | |||
| const str3 = str2 !== -1 ? str.slice(0, str2) : str | |||
There was a problem hiding this comment.
this change significantly shortens error messages
cmdcolin
force-pushed
the
gccontenttrack
branch
from
ad25fa8
to
ec0eff8
Compare
cmdcolin
force-pushed
the
gccontenttrack
branch
from
ec0eff8
to
8437a87
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4288 +/- ##
==========================================
+ Coverage 62.60% 62.64% +0.03%
==========================================
Files 1088 1092 +4
Lines 31496 31498 +2
Branches 7528 7527 -1
==========================================
+ Hits 19719 19732 +13
+ Misses 11602 11593 -9
+ Partials 175 173 -2 ☔ View full report in Codecov by Sentry. |
|
additional tooling could allow a user to auto-create this track from the 'add-assembly' cli or from gui potentially. but, might be ok for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this incorporates the "GC content display" but is a separate track type
it requires cloning the display type since a display can only be registered to one track type at a time