Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Hi-C rendering for some high resolution files #4319

Merged
merged 1 commit into from Mar 28, 2024
Merged

Fix Hi-C rendering for some high resolution files #4319

merged 1 commit into from Mar 28, 2024

Conversation

cmdcolin
Copy link
Collaborator

assumed that it should shift the offset by the bp coordinate of the "first data line in the file" but this is actually wrong when it is sparse...I believe the correct shift is just the region start bp coordinate

@cmdcolin
Copy link
Collaborator Author

fixes #4316

@cmdcolin cmdcolin changed the title Possible fix for Hi-C rendering for sparse files Fix Hi-C rendering for some high resolution files Mar 28, 2024
@cmdcolin cmdcolin merged commit 9789c42 into main Mar 28, 2024
10 checks passed
@cmdcolin cmdcolin deleted the hic_fix branch March 28, 2024 13:58
@cmdcolin cmdcolin added the bug Something isn't working label Mar 28, 2024
cmdcolin added a commit that referenced this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant