Add new Hi-C color schemes with log scale mode #4336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmdcolin
force-pushed
the
hic_color_schemes
branch
from
d7eff01
to
daf83ce
Compare
This was referenced Apr 15, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes advantage of d3 color scales to add both linear and log color scalings for hi-c. Built-in selectable options are "fall", "viridis", and "juicebox"
Fixes #4331
Example screenshots
the aim is for these easy settings to override any config-defined renderer->color callback setting, similar to other types of "state" variables. the "scale interpolator" is actually passed into the color callback so a user defined setting can choose to use it or not. with this, it may be hard for a user to create their own proper d3 color scale but that could be added on