Improve error dialog stack trace display and fix usage on https sites #4341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
cmdcolin
commented
Apr 12, 2024
cmdcolin
commented
- fixes usage on https sites
- small data display improvements
cmdcolin
force-pushed
the
improve_error_display2
branch
from
f2740a5
to
3f6fb7f
Compare
cmdcolin
commented
Apr 12, 2024
| @@ -71,7 +72,7 @@ async function mapStackTrace(stack: string) { | |||
| const mappedStack = [] | |||
|
|
|||
| for (const line of stackLines) { | |||
| const match = new RegExp(/(.*)(http:\/\/.*):(\d+):(\d+)/).exec(line) | |||
| const match = new RegExp(/(.*)(https?:\/\/.*):(\d+):(\d+)/).exec(line) | |||
There was a problem hiding this comment.
key line that was not working for https sites
cmdcolin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.