Replace all rgba(...) color strings with rgb(...) in SVG exports to fix usage in illustrator/inkscape #4381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmdcolin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From office hours today, a user noted that the scale bar from wiggle plots does not show up in tools like adobe illustrator
This has been seen before due to illustrator and inkscape not supporting rgba color strings
This PR runs a very coarse-level string-regex-strip that replaces rgba(r,g,b,a) with rgb(r,g,b)
The ideal might be to also add the separate opacity prop when this is encountered but this PR at least makes it so that the contents will show up instead of being totally un-renderable