Skip to content

Commit

Permalink
make bigbed features have unique IDs based on their file offset. good…
Browse files Browse the repository at this point in the history
… catch @cmdcolin
  • Loading branch information
rbuels committed Apr 17, 2018
1 parent d0c93e3 commit 99f3849
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
1 change: 1 addition & 0 deletions src/JBrowse/Store/SeqFeature/BigWig/RequestWorker.js
Expand Up @@ -356,6 +356,7 @@ var RequestWorker = declare( null,
}

const featureData = this.parseBedText(start, end, rest)
featureData.id = `bb-${startOffset + offset}`
this.maybeCreateFeature(start,end,featureData)
}
},
Expand Down
2 changes: 1 addition & 1 deletion tests/data/human_bigbed/ENST00000610940.4.json
Expand Up @@ -49,5 +49,5 @@
"gene_bio_type": "protein_coding",
"tags": "basic,appris_principal_3,CCDS"
},
"_uniqueID": "18912776_18936553_1000"
"_uniqueID": "bb-53429"
}
8 changes: 4 additions & 4 deletions tests/data/volvox.bb.expected.json
Expand Up @@ -28,7 +28,7 @@
"gene_bio_type": "-",
"tags": "-"
},
"_uniqueID": "1049_9000_1000"
"_uniqueID": "bb-94"
},
{
"data": {
Expand Down Expand Up @@ -57,7 +57,7 @@
"gene_bio_type": "-",
"tags": "-"
},
"_uniqueID": "1049_9000_1000"
"_uniqueID": "bb-179"
},
{
"data": {
Expand Down Expand Up @@ -88,7 +88,7 @@
"gene_bio_type": "-",
"tags": "-"
},
"_uniqueID": "1299_9000_1000"
"_uniqueID": "bb-273"
},
{
"data": {
Expand Down Expand Up @@ -117,6 +117,6 @@
"gene_bio_type": "-",
"tags": "-"
},
"_uniqueID": "17399_23000_1000"
"_uniqueID": "bb-377"
}
]

0 comments on commit 99f3849

Please sign in to comment.