empty container before showing dataset selection page, fixes #1057

GMOD · May 31, 2018 · c186e11 · c186e11
1 parent d4a1a56
commit c186e11
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/release-notes.md b/release-notes.md
@@ -12,6 +12,10 @@
  * Fixed a bug in which setup.sh did not accept nodejs version 10 as sufficiently recent.
    (pull #1048, @cmdcolin)
 
+ * Fixed a bug in which the "Loading..." message erroneously appeared at the top of the
+   dataset-selection page. Many thanks to @srobb1 for noticing this and reporting it!
+   (issue #1057, @rbuels)
+
 # Release 1.14.1     2018-05-02 22:04:33 UTC
 
 ## Minor improvements

diff --git a/src/JBrowse/Browser.js b/src/JBrowse/Browser.js
@@ -467,6 +467,7 @@ fatalError: function( error ) {
             && this.config.datasets
             && ! this.config.datasets._DEFAULT_EXAMPLES
           ) {
+            dojo.empty(this.container)
             new StandaloneDatasetList({ datasets: this.config.datasets })
                   .placeAt( this.container );
         } else {