RadioMenuItem is too confusing

GMOD · Nov 6, 2018 · ff8632e · ff8632e
1 parent 0b0ba00
commit ff8632e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 13 deletions.
diff --git a/src/JBrowse/View/Track/Alignments2.js b/src/JBrowse/View/Track/Alignments2.js
@@ -83,22 +83,19 @@ return declare( [ CanvasFeatureTrack, AlignmentsMixin ], {
             });
         }
 
-
         displayOptions.push({
             label: 'View coverage',
-            type: 'dijit/RadioMenuItem',
-            group: 'g2',
             onClick: function(event) {
                 thisB.config.type = 'JBrowse/View/Track/SNPCoverage'
                 thisB.config._oldAlignmentsHeight = thisB.config.style.height
                 thisB.config.style.height = thisB.config._oldSnpCoverageHeight
                 thisB.browser.publish('/jbrowse/v1/v/tracks/replace', [thisB.config]);
             }
         });
+
+        console.log(this.config.viewAsPairs == false && this.config.readCloud == false)
         displayOptions.push({
             label: 'View normal',
-            type: 'dijit/RadioMenuItem',
-            group: 'g2',
             onClick: function(event) {
                 thisB.config.viewAsPairs = false
                 thisB.config.readCloud = false
@@ -107,10 +104,10 @@ return declare( [ CanvasFeatureTrack, AlignmentsMixin ], {
             }
         });
 
+
+            console.log('t1',this.config.viewAsPairs == true && this.config.readCloud == false)
         displayOptions.push({
             label: 'View as pairs',
-            type: 'dijit/RadioMenuItem',
-            group: 'g2',
             onClick: function(event) {
                 thisB.config.viewAsPairs = true
                 thisB.config.readCloud = false
@@ -121,8 +118,6 @@ return declare( [ CanvasFeatureTrack, AlignmentsMixin ], {
 
         displayOptions.push({
             label: 'View paired arcs',
-            type: 'dijit/RadioMenuItem',
-            group: 'g2',
             onClick: function(event) {
                 thisB.config.viewAsPairs = true
                 thisB.config.readCloud = true
@@ -132,8 +127,6 @@ return declare( [ CanvasFeatureTrack, AlignmentsMixin ], {
         });
         displayOptions.push({
             label: 'View pairs as read cloud',
-            type: 'dijit/RadioMenuItem',
-            group: 'g2',
             onClick: function(event) {
                 thisB.config.viewAsPairs = true
                 thisB.config.readCloud = true

diff --git a/src/JBrowse/View/Track/BlockBased.js b/src/JBrowse/View/Track/BlockBased.js
@@ -19,6 +19,7 @@ define( [
             'dijit/MenuItem',
             'dijit/CheckedMenuItem',
             'dijit/MenuSeparator',
+            'dijit/RadioMenuItem',
             'JBrowse/Util',
             'JBrowse/Component',
             'JBrowse/FeatureFiltererMixin',
@@ -49,6 +50,7 @@ define( [
                   dijitMenuItem,
                   dijitCheckedMenuItem,
                   dijitMenuSeparator,
+                  dijitRadioMenuItem,
                   Util,
                   Component,
                   FeatureFiltererMixin,
@@ -767,6 +769,7 @@ return declare( [Component,DetailsMixin,FeatureFiltererMixin,Destroyable],
                     var class_ = {
                         'dijit/MenuItem':        dijitMenuItem,
                         'dijit/CheckedMenuItem': dijitCheckedMenuItem,
+                        'dijit/RadioMenuItem':   dijitRadioMenuItem,
                         'dijit/MenuSeparator':   dijitMenuSeparator
                     }[spec.type] || dijitMenuItem;
 

diff --git a/src/JBrowse/View/Track/SNPCoverage.js b/src/JBrowse/View/Track/SNPCoverage.js
@@ -287,8 +287,6 @@ return declare( [WiggleXY, AlignmentsMixin],
 
         displayOptions.push({
             label: 'View alignments',
-            type: 'dijit/RadioMenuItem',
-            group: 'g2',
             onClick: function(event) {
                 thisB.config.type = 'JBrowse/View/Track/Alignments2'
                 thisB.config._oldSnpCoverageHeight = thisB.config.style.height