Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto lower case gff and nclist feature.get arguments #1074

Merged
merged 2 commits into from Jun 30, 2018
Merged

Auto lower case gff and nclist feature.get arguments #1074

merged 2 commits into from Jun 30, 2018

Conversation

cmdcolin
Copy link
Contributor

This is a PR that adds auto-lower-casing the feature.get('...') argument for NCList ArrayRepr features and SimpleFeature objects

This helps #1068

I can't forsee any negative consequences because the attributes are already lowercased

@ghost ghost assigned cmdcolin Jun 23, 2018
@ghost ghost added the in progress currently being worked on label Jun 23, 2018
@cmdcolin cmdcolin mentioned this pull request Jun 23, 2018
Closed
@rbuels rbuels added this to the 1.15.0 milestone Jun 30, 2018
@rbuels
Copy link
Collaborator

rbuels commented Jun 30, 2018

@cmdcolin could you add a release note

@rbuels rbuels merged commit ab12eb6 into dev Jun 30, 2018
@ghost ghost removed the in progress currently being worked on label Jun 30, 2018
@cmdcolin cmdcolin deleted the auto_lower_case branch July 11, 2018 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cmdcolin cmdcolin

Labels
None yet
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cmdcolin @rbuels