New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bam dialog matches #795
Bam dialog matches #795
Conversation
we can compare the output of sam2pairwise as a reference for this too. https://github.com/mlafave/sam2pairwise it seems to match the output as expected |
@cmdcolin , the only other thing I'd like to see is (if possible) wrapping the display like GBrowse does, e.g. |
@keiranmraine Added that "newline based" rendering behind a config flag (renderAlignment.newlines). Width can be configured as renderAlignment.width |
bbbed16
to
9f030b9
Compare
@cmdcolin, that works well thanks! |
Any ETA on a merge for this? |
bbc44de
to
074262c
Compare
I made this feature optional and off by default (i.e. introduce the feature behind a feature flag) so would maybe be safe to merge and interested users can enable it if interested. |
Given that this is behind a feature flag, would it be ok to merge this one? I just know it was requested by @keiranmraine and having something like this available can be pretty useful when inspecting alignments |
0ee090b
to
d9da753
Compare
431019c
to
b539cb9
Compare
b539cb9
to
942bd49
Compare
I think we're gonna try and get this merged behind feature flag! that way it can get tested and improved :) |
This is a PR to address the feature request in #496
The algorithm is able to reconstruct the alignment from the BAM read sequence+MD tag+CIGAR string
I created some test cases to handle some common scenarios addressed by the algorithm (insertion, deletion, soft clipping reads)