Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bam dialog matches #795

Merged
merged 32 commits into from Mar 22, 2017
Merged

Bam dialog matches #795

merged 32 commits into from Mar 22, 2017

Conversation

cmdcolin
Copy link
Contributor

@cmdcolin cmdcolin commented Aug 1, 2016

This is a PR to address the feature request in #496

The algorithm is able to reconstruct the alignment from the BAM read sequence+MD tag+CIGAR string

I created some test cases to handle some common scenarios addressed by the algorithm (insertion, deletion, soft clipping reads)

@nathandunn nathandunn added the in progress currently being worked on label Aug 1, 2016
@cmdcolin cmdcolin removed the in progress currently being worked on label Aug 1, 2016
@cmdcolin
Copy link
Contributor Author

cmdcolin commented Aug 4, 2016

we can compare the output of sam2pairwise as a reference for this too. https://github.com/mlafave/sam2pairwise

it seems to match the output as expected

@keiranmraine
Copy link
Contributor

@cmdcolin , the only other thing I'd like to see is (if possible) wrapping the display like GBrowse does, e.g.

screen shot 2016-08-04 at 09 03 12

@cmdcolin
Copy link
Contributor Author

cmdcolin commented Aug 5, 2016

@keiranmraine Added that "newline based" rendering behind a config flag (renderAlignment.newlines). Width can be configured as renderAlignment.width

@cmdcolin cmdcolin force-pushed the bam_dialog_matches branch 4 times, most recently from bbbed16 to 9f030b9 Compare August 5, 2016 21:18
@keiranmraine
Copy link
Contributor

@cmdcolin, that works well thanks!

@keiranmraine
Copy link
Contributor

Any ETA on a merge for this?

@cmdcolin cmdcolin force-pushed the bam_dialog_matches branch 2 times, most recently from bbc44de to 074262c Compare March 22, 2017 19:48
@cmdcolin
Copy link
Contributor Author

I made this feature optional and off by default (i.e. introduce the feature behind a feature flag) so would maybe be safe to merge and interested users can enable it if interested.

@cmdcolin
Copy link
Contributor Author

Given that this is behind a feature flag, would it be ok to merge this one?

I just know it was requested by @keiranmraine and having something like this available can be pretty useful when inspecting alignments

@cmdcolin
Copy link
Contributor Author

some screenshots:

normal short read
screenshot-localhost-2017-03-22-17-03-58 1

long read
screenshot-localhost-2017-03-22-17-10-46 1

rna-seq read
screenshot-localhost-2017-03-22-17-11-02 1

note that the alignment is constructed entirely from the MD tag and CIGAR string so it doesn't need to retreive reference sequence track data

@cmdcolin cmdcolin force-pushed the bam_dialog_matches branch 2 times, most recently from 431019c to b539cb9 Compare March 22, 2017 22:04
@cmdcolin
Copy link
Contributor Author

I think we're gonna try and get this merged behind feature flag! that way it can get tested and improved :)

@cmdcolin cmdcolin merged commit 4fd08b5 into master Mar 22, 2017
@cmdcolin cmdcolin deleted the bam_dialog_matches branch March 23, 2017 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants