Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kororaa Fix: location name missing in legend #147

Closed
chrisdicaprio opened this issue Sep 14, 2022 · 1 comment
Closed

Kororaa Fix: location name missing in legend #147

chrisdicaprio opened this issue Sep 14, 2022 · 1 comment
Assignees

Comments

@chrisdicaprio
Copy link
Collaborator

chrisdicaprio commented Sep 14, 2022

When plotting Whangarei, Pukekohe, Hamilton, and Lower Hutt the plots show the Lat,Lon co-ordinates rather than an acronym for the location.

FIXES:

  • ADD Whangarei (WLZ) - added to nshm-common-py (needs API release)
  • UPDATE Hamilton (HLZ) - tweaks Kororaa location
  • REMOVE Pukekohe
  • REMOVE Lower Hutt
  • ADD
    • {"id": "ZWG", "name": "Whanganui", "latitude": -39.93, "longitude": 175.05},
    • {"id": "ZTR", "name": "Turangi", "latitude": -39.0, "longitude": 175.93},
    • {"id": "ZOT", "name": "Otira", "latitude": -42.78, "longitude": 171.54},
    • {"id": "ZHT", "name": "Haast", "latitude": -43.88, "longitude": 169.06},
    • {"id": "ZHS", "name": "Hanmer Springs", "latitude": -42.54, "longitude": 172.78},

possible future Fix: rather than use a stale lookup table, get the location names/acronyms from K-API. See GNS-Science/kororaa-graphql-api#40

@chrisbc
Copy link
Member

chrisbc commented Sep 15, 2022

@benjamineac the 'stale lookup table' CDC refers to is this const in hazardCharts/constants/hazardPageOptions.ts but I'm not sure exactly what's going on here. Need to do some testing on API

export const hazardPageLocations: HazardPageLocations[] = [
 {
    id: 'WLG',
    name: 'Wellington',
    latitude: -41.3,
    longitude: 174.78,
    population: 200000,
  },
  ....

@chrisbc chrisbc self-assigned this Sep 26, 2022
@chrisbc chrisbc closed this as completed Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants