-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Encoding AV1 with color range "Full" outputs wrong colors #398
Comments
Could you please provide more details why you consider the result as an error? |
Please see "original background image", the full color range screenshot is blacker than original. In a properly implemented color space, the player correctly displays limited and full as near-consistent colors. And it differs from other implementations (AMF H264/H265 or SVT-AV1/AOM AV1). mediainfo outputs of AOM-limited:
mediainfo outputs of AOM-full:
|
And here have some test charts: Video: test_charts.zip |
I believe the issue lies with the tags/flags. When parsing the bitstream, the color range shows: Both FFmpeg, MPV and VLC reads the file as being partial range color (incorrect), hence the values being mishandeled, resulting in the full/partial mismatch. |
I was confused by MediaInfo. It says "Full". Yes, both clips have color_range = 0. I've opened internal ticket. Thanks. |
Describe the bug
Encoding AV1 with color range "Full" outputs file has wrong color.
To Reproduce
Steps to reproduce the behavior:
AMF_VIDEO_ENCODER_AV1_OUTPUT_COLOR_PROFILE
=AMF_VIDEO_CONVERTER_COLOR_PROFILE_709
.AMF_VIDEO_ENCODER_AV1_OUTPUT_COLOR_PROFILE
=AMF_VIDEO_CONVERTER_COLOR_PROFILE_FULL_709
.Setup (please complete the following information):
Expected behavior
For the different color range "limited" and "full" the colors should be nearly identical when viewed with the naked eye.
Screenshots
Screenshot of
limited
:Screenshot of
full
:The original background image:
Additional context
mediainfo outputs of
limited
:mediainfo outputs of
full
:example videos.zip
And in AMF_Video_Encode_AV1_API.md -
Name: AMF_VIDEO_ENCODER_AV1_OUTPUT_COLOR_PROFILE
:But
NOMINAL_RANGE
isn't available in VideoEncoderAV1.hOriginal issue: obsproject/obs-studio#9121
The text was updated successfully, but these errors were encountered: